Skip to content

Commit a63b379

Browse files
skip flaky browser render test on Windows (#10311)
1 parent 3b6ab8a commit a63b379

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

packages/miniflare/test/plugins/browser/index.spec.ts

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -180,17 +180,21 @@ export default {
180180
};
181181
`;
182182

183-
test.serial("fails if browser session already in use", async (t) => {
184-
const opts: MiniflareOptions = {
185-
name: "worker",
186-
compatibilityDate: "2024-11-20",
187-
modules: true,
188-
script: BROWSER_WORKER_ALREADY_USED_SCRIPT,
189-
browserRendering: { binding: "MYBROWSER" },
190-
};
191-
const mf = new Miniflare(opts);
192-
t.teardown(() => mf.dispose());
193-
194-
const res = await mf.dispatchFetch("https://localhost");
195-
t.is(await res.text(), "Failed to connect to browser session");
196-
});
183+
const isWindows = process.platform === "win32";
184+
(isWindows ? test.skip : test.serial)(
185+
"fails if browser session already in use",
186+
async (t) => {
187+
const opts: MiniflareOptions = {
188+
name: "worker",
189+
compatibilityDate: "2024-11-20",
190+
modules: true,
191+
script: BROWSER_WORKER_ALREADY_USED_SCRIPT,
192+
browserRendering: { binding: "MYBROWSER" },
193+
};
194+
const mf = new Miniflare(opts);
195+
t.teardown(() => mf.dispose());
196+
197+
const res = await mf.dispatchFetch("https://localhost");
198+
t.is(await res.text(), "Failed to connect to browser session");
199+
}
200+
);

0 commit comments

Comments
 (0)