Merge pull request #1605 from cloudflare/promql/impssible

Check for dead labels in joins

Author: prymitive

cmd/pint/tests/0001_match_path.txt

@@ -9,8 +9,8 @@ level=INFO msg="Checking Prometheus rules" entries=2 workers=10 online=true
 Bug: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0002.yml:2 -> `colo:test2`
 2 |   expr: sum(foo) without(job)
-                     ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                             `job` label is required and should be preserved when aggregating all rules.
+                             ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                 `job` label is required and should be preserved when aggregating all rules.
 
 level=INFO msg="Problems found" Bug=1
 level=ERROR msg="Execution completed with error(s)" err="found 1 problem(s) with severity Bug or higher"

cmd/pint/tests/0003_lint_workdir.txt

@@ -10,8 +10,8 @@ level=INFO msg="Checking Prometheus rules" entries=19 workers=10 online=true
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0001.yml:2 -> `colo_job:fl_cf_html_bytes_in:rate10m`
 2 |   expr: sum(rate(fl_cf_html_bytes_in[10m])) WITHOUT (colo_id, instance, node_type, region, node_status, job, colo_name)
-                                                ^^^^^^^^ Query is using aggregation with `without(colo_id, instance, node_type, region, node_status, job, colo_name)`, all labels included inside `without(...)` will be removed from the results.
-                                                         `job` label is required and should be preserved when aggregating all rules.
+                                                                                                            ^^^ Query is using aggregation with `without(colo_id, instance, node_type, region, node_status, job, colo_name)`, all labels included inside `without(...)` will be removed from the results.
+                                                                                                                `job` label is required and should be preserved when aggregating all rules.
 
 Warning: label must be removed in aggregations (promql/aggregate)
   ---> rules/0001.yml:6 -> `colo_job:foo:irate3m` [+3 duplicates]
@@ -31,8 +31,8 @@ Warning: redundant regexp (promql/regexp)
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0003.yaml:11 -> `colo_job:up:count` [+1 duplicates]
 11 |   expr: sum(foo) without(job)
-                      ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                              `job` label is required and should be preserved when aggregating all rules.
+                              ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                  `job` label is required and should be preserved when aggregating all rules.
 
 Fatal: PromQL syntax error (promql/syntax)
   ---> rules/0003.yaml:14 -> `invalid`
@@ -44,8 +44,8 @@ Warning: required label is being removed via aggregation (promql/aggregate)
 23 |     sum(
 24 |       multiline
 25 |     ) without(job, instance)
-           ^^^^^^^ Query is using aggregation with `without(job, instance)`, all labels included inside `without(...)` will be removed from the results.
-                   `job` label is required and should be preserved when aggregating all rules.
+                   ^^^ Query is using aggregation with `without(job, instance)`, all labels included inside `without(...)` will be removed from the results.
+                       `job` label is required and should be preserved when aggregating all rules.
 
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0003.yaml:40 -> `colo_job:up:byinstance`

cmd/pint/tests/0008_recording_rule_prometheus.txt

@@ -15,7 +15,7 @@ Warning: required label is being removed via aggregation (promql/aggregate)
 Bug: label must be removed in aggregations (promql/aggregate)
   ---> rules/0001.yml:5 -> `colo:http_inprogress_requests:sum`
 5 |       expr: sum by (instance) (http_inprogress_requests)
-                    ^^^ `instance` label should be removed when aggregating `^colo(?:_.+)?:.+$` rules.
+                        ^^^^^^^^ `instance` label should be removed when aggregating `^colo(?:_.+)?:.+$` rules.
 
 level=INFO msg="Problems found" Bug=1 Warning=1
 level=ERROR msg="Execution completed with error(s)" err="found 1 problem(s) with severity Bug or higher"

cmd/pint/tests/0011_ignore_rules.txt

@@ -14,8 +14,8 @@ Fatal: PromQL syntax error (promql/syntax)
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/1.yaml:16 -> `active` [+1 duplicates]
 16 |   expr: sum(errors_total) without(job)
-                               ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                                       `job` label is required and should be preserved when aggregating all rules.
+                                       ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                           `job` label is required and should be preserved when aggregating all rules.
 
 Warning: always firing alert (alerts/comparison)
   ---> rules/1.yaml:33 -> `active`

cmd/pint/tests/0018_match_alerting.txt

@@ -22,8 +22,8 @@ Warning: always firing alert (alerts/comparison)
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0001.yml:5 -> `colo:alerting`
 5 |   expr: sum(bar) without(job)
-                     ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                             `job` label is required and should be preserved when aggregating all rules.
+                             ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                 `job` label is required and should be preserved when aggregating all rules.
 
 level=INFO msg="Problems found" Warning=2
 -- rules/0001.yml --

cmd/pint/tests/0019_match_recording.txt

@@ -17,8 +17,8 @@ level=DEBUG msg="Configured checks for rule" enabled=["promql/syntax","alerts/fo
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0001.yml:2 -> `colo:recording`
 2 |   expr: sum(foo) without(job)
-                     ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                             `job` label is required and should be preserved when aggregating all rules.
+                             ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                 `job` label is required and should be preserved when aggregating all rules.
 
 level=INFO msg="Problems found" Warning=1
 -- rules/0001.yml --

cmd/pint/tests/0020_ignore_kind.txt

@@ -17,8 +17,8 @@ level=DEBUG msg="Configured checks for rule" enabled=["promql/syntax","alerts/fo
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0001.yml:5 -> `colo:recording`
 5 |     expr: sum(foo) without(job)
-                       ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                               `job` label is required and should be preserved when aggregating all rules.
+                               ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                   `job` label is required and should be preserved when aggregating all rules.
 
 Warning: always firing alert (alerts/comparison)
   ---> rules/0001.yml:8 -> `colo:alerting`

cmd/pint/tests/0022_ignore_multi.txt

@@ -9,13 +9,13 @@ level=INFO msg="Checking Prometheus rules" entries=3 workers=10 online=true
 Warning: label must be removed in aggregations (promql/aggregate)
   ---> rules/1.yaml:2 -> `disabled`
 2 |   expr: sum(errors_total) by(keep,dropped)
-                              ^^ `dropped` label should be removed when aggregating all rules.
+                                      ^^^^^^^ `dropped` label should be removed when aggregating all rules.
 
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/1.yaml:5 -> `B`
 5 |   expr: sum(errors_total) without(keep,dropped)
-                              ^^^^^^^ Query is using aggregation with `without(keep, dropped)`, all labels included inside `without(...)` will be removed from the results.
-                                      `keep` label is required and should be preserved when aggregating all rules.
+                                      ^^^^ Query is using aggregation with `without(keep, dropped)`, all labels included inside `without(...)` will be removed from the results.
+                                           `keep` label is required and should be preserved when aggregating all rules.
 
 level=INFO msg="Problems found" Warning=2
 -- rules/1.yaml --

cmd/pint/tests/0024_color_output.txt

@@ -10,8 +10,8 @@ cmp stderr stderr.txt
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0001.yml:2 -> `colo_job:fl_cf_html_bytes_in:rate10m`
 2 |   expr: sum(rate(fl_cf_html_bytes_in[10m])) WITHOUT (colo_id, instance, node_type, region, node_status, job, colo_name)
-                                                ^^^^^^^^ Query is using aggregation with `without(colo_id, instance, node_type, region, node_status, job, colo_name)`, all labels included inside `without(...)` will be removed from the results.
-                                                         `job` label is required and should be preserved when aggregating all rules.
+                                                                                                            ^^^ Query is using aggregation with `without(colo_id, instance, node_type, region, node_status, job, colo_name)`, all labels included inside `without(...)` will be removed from the results.
+                                                                                                                `job` label is required and should be preserved when aggregating all rules.
 
 Warning: label must be removed in aggregations (promql/aggregate)
   ---> rules/0001.yml:6 -> `colo_job:foo:irate3m` [+3 duplicates]
@@ -21,8 +21,8 @@ cmp stderr stderr.txt
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0003.yaml:11 -> `colo_job:up:count` [+1 duplicates]
 11 |   expr: sum(foo) without(job)
-                      ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                              `job` label is required and should be preserved when aggregating all rules.
+                              ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                  `job` label is required and should be preserved when aggregating all rules.
 
 Fatal: PromQL syntax error (promql/syntax)
   ---> rules/0003.yaml:14 -> `invalid`
@@ -34,8 +34,8 @@ cmp stderr stderr.txt
 23 |     sum(
 24 |       multiline
 25 |     ) without(job, instance)
-           ^^^^^^^ Query is using aggregation with `without(job, instance)`, all labels included inside `without(...)` will be removed from the results.
-                   `job` label is required and should be preserved when aggregating all rules.
+                   ^^^ Query is using aggregation with `without(job, instance)`, all labels included inside `without(...)` will be removed from the results.
+                       `job` label is required and should be preserved when aggregating all rules.
 
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0003.yaml:40 -> `colo_job:up:byinstance`

cmd/pint/tests/0052_match_multiple.txt

@@ -17,8 +17,8 @@ level=DEBUG msg="Configured checks for rule" enabled=["promql/syntax","alerts/fo
 Warning: required label is being removed via aggregation (promql/aggregate)
   ---> rules/0001.yml:5 -> `colo:recording` [+1 duplicates]
 5 |     expr: sum(foo) without(job)
-                       ^^^^^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
-                               `job` label is required and should be preserved when aggregating all rules.
+                               ^^^ Query is using aggregation with `without(job)`, all labels included inside `without(...)` will be removed from the results.
+                                   `job` label is required and should be preserved when aggregating all rules.
 
 level=INFO msg="Some problems are duplicated between rules and all the duplicates were hidden, pass `--show-duplicates` to see them" total=2 duplicates=1 shown=1
 level=INFO msg="Problems found" Warning=2