Fix prerendered dynamic ISR functions change in Vercel CLI

[james-elicx]

new vercel cli update no longer generates prerender configs for dynamic ISR functions when it generates valid children for the route.

this pr does the following:

• checks if invalid func is a dynamic isr function
• if it is, it checks if there is prerendered function for the dynamic routes sourcepath
• if there are, it marks the dynamic function as ignored.

fixes #833

source path in prerender config for reference:

[changeset-bot]

🦋 Changeset detected

Latest commit: 0977ef3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@cloudflare/next-on-pages	Patch
eslint-plugin-next-on-pages	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🧪 Prereleases are available for testing 🧪

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10039763616/npm-package-next-on-pages-834

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/10039763616/npm-package-eslint-plugin-next-on-pages-834

[dario-piotrowicz]

Looks good to me, thanks a lot for the fix @james-elicx 🙏

I've just left a few minor comments

[valentinbdv]

Hi @dario-piotrowicz and @james-elicx. Thank you so much for your responsiveness in finding this quick fix. I'm currently stuck with this problem, so to see it progressing at this rate is great!
Do you know when the fix will be available using the command npx @cloudflare/next-on-pages@1? I'd like to know approximately when I'll be able to publish my project again.
Have a wonderful day ;)

[dario-piotrowicz]

Hi @valentinbdv 🙂, no problem (well, James did all the work here! :P)

I'm sorry you've been blocked, if you want this should already be available in npx @cloudflare/next-on-pages@beta (since we publish that on every merge)

Or in any case I will cut a next-on-pages stable release today at some point, so by tomorrow npx @cloudflare/next-on-pages@1 should also include the fix 🙂

[valentinbdv]

Hi @dario-piotrowicz, I can confirm it does work now using npx @cloudflare/next-on-pages@beta !!
Tomorrow is perfect, thanks again ;)

[dario-piotrowicz]

@valentinbdv nice! 😄 anyways I've also just done a stable release so feel free to go back to @1 🙂

[valentinbdv]

Hi @dario-piotrowicz, it seems that npx @cloudflare/next-on-pages@1 still doesn't include the fix unfortunately while there is a new version published after your fix.
How long do you think it will take then? Thanks!

[valentinbdv]

Oh sorry, I forgot to upgrade next-on-pages@1 before testing again. It works now ;)
For your information, I still have the warning message Invalid prerender config for /target/[target] but this is maybe due to something else.

[JoE11-y]

HI @dario-piotrowicz, I tried and still can't seem to get it to work?

[dario-piotrowicz]

@JoE11-y can you make sure that you're using the latest (1.13.2) version of next-on-pages?

To be sure you can check the version that gets printed when you run the build command:

If you're indeed using the latest next-on-pages version and it still doesn't work for you, could you please open a new issue with a minimal reproduction? (and I'll look into it as soon as I can) 🙏