Set x-matched-path
fixing dynamic routing
#51
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures
x-matched-path
is set, soNext.js#handleRequest
is able to recognize and render dynamic routes.It appears Next.js uses this header pretty extensively in it's base-server, to determine whether or not we're in an edge runtime. Without this header, Next.js doesn't match the URL segments resulting in a "Internal Server Error" page.
I'm happy to change any part of this PR, but think this might be one of the "cleaner" solutions I've been able to come up with.
I've also created a reproduction of this bug, along with a patched version of
next-on-pages
that proves that this solution works over here: https://github.com/hanford/next-on-pages-32closes #32