fix: support mTLS in 1.0 Binary and Structured emitters #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies both of the 1.0 emitters so that they may accept typed objects as a part of the configuration. When using mTLS in Node, you need to provide an `Agent` to the underlying HTTP handler. In this case, Axios will pass this object along to Node.js when it is provided. Fixes: cloudevents#48 Signed-off-by: Lance Ball <[email protected]>
|
@lance, please sign off the commits. |
|
Looks like GitHub has caught up |
Signed-off-by: Lance Ball <[email protected]>
|
@lance, please fill the CHANGELOG.md with those changes and the warning about <0.3 support. |
Signed-off-by: Lance Ball <[email protected]>
|
@fabiojose anything else you are interested in seeing here? |
|
LGTM |
lance
added
the
version/1.x.backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies both of the 1.0 emitters so that they may
accept typed objects as a part of the configuration. When using
mTLS in Node, you need to provide an
Agentto the underlyingHTTP handler. In this case, Axios will pass this object along to
Node.js when it is provided.
Note: This does not address the issue in 0.3 or below.
Fixes: #48
Signed-off-by: Lance Ball [email protected]