-
Notifications
You must be signed in to change notification settings - Fork 70
chore: release 4.0.0 #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 4.0.0 #341
Conversation
f40c50e
to
4243137
Compare
4243137
to
d6e0da1
Compare
@lholmquist something seems wrong with the changelog here. It should not have all of these commits. Locally, when I try to see what has changed between v3.2.0 and HEAD, I see this. ❯ git log b9ed2619c0362390c221e9bf8bf61deea7bd83fd..HEAD --oneline
e334b6e (HEAD -> main, origin/main) feat: add emitterFactory and friends (#342)
a9114b7 chore: add an automated GH action for releases (#329)
eca43d9 fix: package.json & package-lock.json to reduce vulnerabilities (#338)
0a12146 docs: update README with maintainer names (#337)
1fa3a05 feat: add a constructor parameter for loose validation (#328)
7423acb fix: upgrade cloudevents from 3.0.1 to 3.1.0 (#335)
4779d89 chore(example): Replaced body parser with express JSON parser (#334)
6cd310c src(event)!: make the event's time property only a string (#330)
f3953a9 (v3.2.x) feat: introduce Message, Serializer, Deserializer and Binding interfaces (#324)
17d4bc8 chore: add cucumber.js to list of files to lint and /docs to .gitignore (#327)
73f0bec chore: Update README with correct links for the support specification versions (#321)
0adcc35 chore: Remove commented version import. (#319)
6e2390e fix: upgrade uuid from 8.2.0 to 8.3.0 (#317)
4bf2eb8 chore: Update references of master to main (#316)
b5cf886 test: implement pending tests leftover from TS rewrite (#315)
8ac3eb0 refactor: validate cloudevent version agnostic (#311)
81623ac chore: typo (#313)
b3624c2 docs: add ref to CoC and other things (#244) However, the output from the GH Action shows this - 585 commits since b9ed261. Run GoogleCloudPlatform/[email protected]
✖ no recent release PRs found
✔ found 585 commits since b9ed2619c0362390c221e9bf8bf61deea7bd83fd
✔ release as major: There are 9 BREAKING CHANGES and 12 features
✔ updating package-lock.json from 3.1.0 to 4.0.0
✖ file samples/package.json did not exist
✔ updating CHANGELOG.md
✔ updating package.json from 3.1.0 to 4.0.0
✔ update pull-request #341: chore: release 4.0.0
✔ adding label autorelease: pending to https://github.com/cloudevents/sdk-javascript/pull/341
✔ cloudevents/sdk-javascript find stale PRs with label "autorelease: pending" |
I have opened an issue upstream to look into this. |
I wonder if we should close this PR then rerun the action now that we’ve
updated the release-please action
…Sent from my iPhone
On Oct 1, 2020, at 3:45 PM, Lance Ball <[email protected]> wrote:
I have opened an issue upstream
<googleapis/release-please-action#78> to
look into this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#341 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH5GUQ3QKXUODC4WOFJV33SITL6RANCNFSM4RQZTZUA>
.
|
At the risk of making things worse... I'm going to try this. |
Closing to see if we can't get the action to work properly now that we've updated the release-please-action version. |
Updated PR is the same #348 |
🤖 I have created a release *beep* *boop*
4.0.0 (2020-10-01)
⚠ BREAKING CHANGES
Features
Bug Fixes
lib
Tests
Miscellaneous
Documentation
This PR was generated with Release Please.