Skip to content

chore: add genertated _bundles to gitignore #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

chore: add genertated _bundles to gitignore #227

merged 1 commit into from
Jun 17, 2020

Conversation

lholmquist
Copy link
Contributor

the _bundles/ was not ignored

Signed-off-by: Lucas Holmquist [email protected]

@lance
Copy link
Member

lance commented Jun 17, 2020

@lholmquist the reason this didn't get ignored is because I wanted to change it to /bundles and did so in .gitignore, but forgot to change it in webpack.config.js. Would you mind modifying this PR to actually change the output directory to bundles?

@lholmquist
Copy link
Contributor Author

ah, sure

@lholmquist lholmquist force-pushed the add__bundles_to_gitignore branch from 58cac50 to b5f6fc2 Compare June 17, 2020 17:11
@lholmquist
Copy link
Contributor Author

updated

lance
lance approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@lance lance merged commit 7012433 into cloudevents:master Jun 17, 2020
@lance lance mentioned this pull request Jul 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@grant grant grant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lholmquist @lance @grant