Skip to content

Drop Support for CloudEvents 0.3 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Drop Support for CloudEvents 0.3 #110

wants to merge 3 commits into from

Conversation

grant
Copy link
Member

@grant grant commented May 1, 2020

This PR drops support for 0.3 CloudEvents.
The main discussion of whether this should be done should continue in the issue (#99).

grant added 3 commits May 1, 2020 11:05
Signed-off-by: Grant Timmerman <[email protected]>
Signed-off-by: Grant Timmerman <[email protected]>
@grant grant self-assigned this May 1, 2020
@lance
Copy link
Member

lance commented May 5, 2020

So, this has been discussed ad nauseum in #99 and on Slack. I am opposed to this change until the 2.0 version of the CE specification has been released. I currently have code that receives Cloud Events from various, unknown sources - some of which are still sending using the 0.3 protocol. I do not want to have this code fail if these event producers are still producing 0.3 events. Until the 2.0 version is released (or release candidate) and there is an implementation of that protocol I think 0.3 should remain.

The SDK requirements doc says this about version compatibility.

  • Each SDK has active points of contact.
  • Each SDK supports the latest(N), and N-1, major releases of the CloudEvent spec*.
  • Within the scope of a major release, only support for the latest minor version is needed.
  • Support for release candidates is not required, but strongly encouraged.
  • Note: v1.0 is a special case and it is recommended that as long as v1.0 is the latest version, SDKs should also support v0.3.

I don't really see the justification for completely dropping support and breaking things for existing users, contrary to recommendations. We will need to continue supporting multiple protocol versions down the line, so this to me seems short sighted.

@helio-frota helio-frota requested review from helio-frota and removed request for helio-frota May 6, 2020 10:47
@helio-frota
Copy link
Contributor

SDKs should also support v0.3.

That seems to be the situation that needs justification according to the RFC which is followed by the spec

So, this has been discussed ad nauseum in #99 and on Slack. I am opposed to this change until the 2.0 version of the CE specification has been released. I currently have code that receives Cloud Events from various, unknown sources - some of which are still sending using the 0.3 protocol. I do not want to have this code fail if these event producers are still producing 0.3 events. Until the 2.0 version is released (or release candidate) and there is an implementation of that protocol I think 0.3 should remain.

I think that is a valid justification so 👎 for dropping 0.3 now.

@lance lance added type/discussion Issues that need to be decided/debated/discussed spec/0.3 Support for spec v0.3 status/stalled Issues that have not made progress recently labels May 6, 2020
@grant grant closed this May 11, 2020
@grant grant deleted the grant_drop_v03 branch May 11, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec/0.3 Support for spec v0.3 status/stalled Issues that have not made progress recently type/discussion Issues that need to be decided/debated/discussed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants