Skip to content

Consider refactoring Cloudevent.format() #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lance opened this issue Apr 29, 2020 · 0 comments · Fixed by #172
Closed

Consider refactoring Cloudevent.format() #88

lance opened this issue Apr 29, 2020 · 0 comments · Fixed by #172
Assignees
@lance
Labels
type/enhancement New feature or request type/question Further information is requested

Comments

@lance
Copy link
Member

lance commented Apr 29, 2020

Based on some discussion in this pull request there are some improvements that could be made to the Cloudevent.format() function.

  • Consider optimizing so that JSON.parse doesn't require several levels of indirection to get to.
  • Expose a way to retrieve the data in multiple formats
  • Consider moving the sanity checks into the spec instance and not in Cloudevent itself.
@lance lance added type/enhancement New feature or request type/question Further information is requested labels Apr 29, 2020
@lance lance self-assigned this May 21, 2020
@lance lance mentioned this issue May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance lance

Labels
type/enhancement New feature or request type/question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib!: change CloudEvent to use direct object notation and get/set properties lance/sdk-javascript
1 participant
@lance