Skip to content

Commit 2cb9364

Browse files
authored
feat!: remove node 12 and node 14 (#545)
* feat!: remove node 12 and node 14 Node 12 has been EOL since the end of April 2022 and Node 14 just became EOL at the end of April 2023 Signed-off-by: Lucas Holmquist <[email protected]>
1 parent 4626529 commit 2cb9364

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.github/workflows/nodejs-ci-action.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
runs-on: ubuntu-latest
1616
strategy:
1717
matrix:
18-
node-version: [12.x, 14.x, 16.x, 18.x]
18+
node-version: [16.x, 18.x, 20.x]
1919

2020
steps:
2121
- uses: actions/checkout@v2

package-lock.json

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,6 @@
158158
},
159159
"types": "./dist/index.d.ts",
160160
"engines": {
161-
"node": ">=12 <=20.0.0"
161+
"node": ">=16 <=20.0.0"
162162
}
163163
}

test/integration/parser_test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ describe("JSON Event Format Parser", () => {
5656
const parser = new Parser();
5757

5858
// TODO: Should the parser catch the SyntaxError and re-throw a ValidationError?
59-
expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError, "Unexpected token g in JSON at position 1");
59+
expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError);
6060
});
6161

6262
it("Accepts a string as valid JSON", () => {

0 commit comments

Comments
 (0)