Update rewrite-clj #342
Update rewrite-clj #342
Conversation
| ^:inline-dep [clj-commons/fs "1.6.307"] | ||
| ^:inline-dep [rewrite-clj "0.6.1"] | ||
| ^:inline-dep [rewrite-clj "1.0.699-alpha"] |
There was a problem hiding this comment.
Do we really need an alpha version here?
There was a problem hiding this comment.
All versions in the 1.x series (i.e @lread's work) are suffixed -alpha. See https://github.com/clj-commons/rewrite-clj#used-in
In practice this means that various modern constructs are better supported (or supported at all)
| @@ -3,16 +3,16 @@ | |||
| :url "http://github.com/clojure-emacs/refactor-nrepl" | |||
| :license {:name "Eclipse Public License" | |||
| :url "http://www.eclipse.org/legal/epl-v10.html"} | |||
| :dependencies [[nrepl "0.8.3"] | |||
| :dependencies [[nrepl "0.9.0-beta3"] | |||
There was a problem hiding this comment.
No super strong rationale other than "keep the important deps @ latest".
It's what cider.el is using as well, which we intend to share with the world as 'stable' soon. So I'd guess 0.9.x would be the version that most realistically will reflect intended usage?
There was a problem hiding this comment.
CIDER uses the latest version only on its snapshot as some features don't work without it. CIDER 1.2 will happen after nREPL 0.9 is finalized. In general I avoid adding deps to betas/alphas unless they are truly needed, although I agree it's not a big deal here.
Fixes #334
Fixes #332
Also, while I was there: