Skip to content

Set clojure-ts-completion-at-point-function locally #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

rrudakov
Copy link
Contributor

We should use add-hook instead of add-to-list in order to set it only for clojure-ts-mode buffers.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

We should use add-hook instead of add-to-list in order to set it only for
clojure-ts-mode buffers.
@bbatsov bbatsov merged commit 01e6a0b into clojure-emacs:main Jun 10, 2025
2 of 3 checks passed
@rrudakov
Copy link
Contributor Author

Tests pass locally. Are we running tests on Emacs master? I suspect the recent change in Emacs could affect the behavior of prog-fill-reindent-defun.

@bbatsov
Copy link
Member

bbatsov commented Jun 10, 2025

Agreed!

@bbatsov
Copy link
Member

bbatsov commented Jun 10, 2025

Tests pass locally. Are we running tests on Emacs master? I suspect the recent change in Emacs could affect the behavior of prog-fill-reindent-defun.

@rrudakov Seems like a mistake in the test matrix, as it is indeed only running the tests on snapshot. Or perhaps it was created before Emacs 29 was released and we forgot to update it.

It's also weird that we run the tests in the lint workflow. Anyways, I'll have those problems fixed.

@rrudakov rrudakov deleted the fix/local-capf branch June 10, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants