[inspector] Fix def-current-value selecting wrong REPL #3757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
fix-def-inspector
branch
from
712e6fa to
9d87502
Compare
alexander-yakushev
force-pushed
the
fix-def-inspector
branch
from
9d87502 to
f2f7164
Compare
bbatsov
approved these changes
Nov 15, 2024
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspector's
cider-inspector-def-current-val(hotkeyd) behaves incorrectly if multiple REPLs are connected. It rebinds our carefully managedcider-inspector--current-replwith(cider-current-repl)which returns whatever in non-file and non-REPL buffers.Perhaps, this is another reminder to make a generic "we know this buffer is associated with this REPL" variable and account for it in
(cider-current-repl).