Replace logical sexp in eval-sexp-and-replace #2929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good to me. Just add a bugfix changelog entry and we're good to go. |
This function find the sexp to evaluate with `clojure-backward-logical-sexp`, but replaces it with `backward-kill-sexp`. This leads to incorrect results, e.g. when eval+replacing `#inst "2020"`, you get `#inst #inst "2020"`.
plexus
force-pushed
the
arne/replace-logical-sexp
branch
from
9a33349 to
6729148
Compare
|
Done! Thanks! |
|
🙇♂️ |
|
Thanks for the quick merge! I may have some other small PRs coming up, trying to clean up my monkey patching :) Starting with the least controversial stuff. https://github.com/plexus/corgi/blob/main/init.el#L129-L208 |
|
Sure! It has been pretty quiet CIDER's front lately, so a few PRs (even controversial ones are quite welcome). |
bbatsov
reviewed
Nov 13, 2020
| (cider-nrepl-sync-request:eval last-sexp) | ||
| ;; seems like the sexp is valid, so we can safely kill it | ||
| (backward-kill-sexp) | ||
| (let ((opoint (point))) |
There was a problem hiding this comment.
Note to myself - this might be an useful function to add in clojure-mode - clojure-backward-kill-logical-sexp.
|
Quiet is good sometimes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function find the sexp to evaluate with
clojure-backward-logical-sexp,but replaces it with
backward-kill-sexp. This leads to incorrect results, e.g.when eval+replacing
#inst "2020", you get#inst #inst "2020".