Skip to content

Conversation

nealsid
Copy link
Contributor

@nealsid nealsid commented Apr 23, 2016

If you set cider-popup-buffer-display to nil, but are using multiple
frames, the call to display-buffer doesn't currently set the required
extra parameter in the alist to stop Emacs from switching to that
frame. This small PR fixes that.

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (make test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)
  • You've updated the refcard (if you made changes to the commands listed there)

@nealsid nealsid closed this Apr 23, 2016
@nealsid nealsid reopened this Apr 23, 2016
cider-popup.el Outdated
buffer `(nil . ((inhibit-same-window . ,pop-up-windows)
(reusable-frames . visible))))))
(reusable-frames . visible)
(inhibit-switch-frame . t))))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess you should add a comment explaining the need for this here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bbatsov
Copy link
Member

bbatsov commented Apr 23, 2016

Looks good to me. Two small things, though:

  • drop the . from the commit's title
  • mention this as a bugfix in the changelog

@nealsid
Copy link
Contributor Author

nealsid commented Apr 24, 2016

Thanks! Addressed your comments. Let me know if anything else is needed.

@bbatsov
Copy link
Member

bbatsov commented Apr 24, 2016

I still don't see a changelog entry for the bugfix.

@nealsid
Copy link
Contributor Author

nealsid commented Apr 25, 2016

Woops, I misunderstood what you meant by Changelog, I thought you meant something else. I'll push another commit later on today. Thanks!

@bbatsov
Copy link
Member

bbatsov commented Apr 29, 2016

ping :-)

If you set cider-popup-buffer-display to nil, but are using multiple
frames, the call to display-buffer doesn't currently set the required
extra parameter in the alist to stop Emacs from switching to that
frame. This small PR is a bugfix for that.
@nealsid
Copy link
Contributor Author

nealsid commented Apr 30, 2016

Done! Really sorry for the delay, this was a crazy week at work. I merged master and rebased my commits. Let me know if anything doesn't look right.

@bbatsov bbatsov merged commit 6938848 into clojure-emacs:master Apr 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants