Don't pass in translations

Author: dpsutton

cider-common.el

@@ -265,7 +265,7 @@ container, the alist would be `((\"/src\" \"~/projects/foo/src\"))"
   :group 'cider
   :package-version '(cider . "0.22.0"))
 
-(defun cider--translate-docker (path translations)
+(defun cider--translate-docker (path)
   "Attempt to translate the PATH.
 Looks at `cider-docker-translations' for (docker . host) alist of path
 prefixes.  TRANSLATIONS is an alist of docker prefix to host prefix."
@@ -274,7 +274,7 @@ prefixes.  TRANSLATIONS is an alist of docker prefix to host prefix."
                 (replace-regexp-in-string (format "^%s" (file-name-as-directory (car translation)))
                                           (file-name-as-directory (cdr translation))
                                           path)))
-            translations))
+            cider-docker-translations))
 
 (defvar cider-from-nrepl-filename-function
   (with-no-warnings
@@ -293,7 +293,7 @@ prefixes.  TRANSLATIONS is an alist of docker prefix to host prefix."
 If no local or remote file exists, return nil."
   (let* ((local-path (funcall cider-from-nrepl-filename-function path))
          (tramp-path (and local-path (cider--client-tramp-filename local-path)))
-         (reverse-docker-path (cider--translate-docker local-path cider-docker-translations)))
+         (reverse-docker-path (cider--translate-docker local-path)))
     (cond ((equal local-path "") "")
           ((and reverse-docker-path (file-exists-p reverse-docker-path)) reverse-docker-path)
           ((and cider-prefer-local-resources (file-exists-p local-path))

test/cider-common-tests.el

@@ -75,20 +75,22 @@
       (expect (cider-make-tramp-prefix "ssh" nil "test.local")
               :to-equal "/ssh:test.local:")))
 
+(defun cider--translate-docker-test (translations file)
+  (let ((cider-docker-translations translations))
+    (cider--translate-docker file)))
+
 (describe "cider--translate-docker"
   (it "translates filepaths from docker location to host location"
-    (expect (cider--translate-docker "/docker/src/namespace.clj"
-                                     '(("/docker/src" . "/home/host/project/src")))
+    (expect (cider--translate-docker-test '(("/docker/src" . "/home/host/project/src"))  "/docker/src/namespace.clj")
             :to-equal "/home/host/project/src/namespace.clj"))
   (it "returns nil if no prefixes match"
-    (expect (cider--translate-docker "/home/host/random/file.clj"
-                                     '(("/docker/src" . "/home/host/project/src")))
+    (expect (cider--translate-docker-test '(("/docker/src" . "/home/host/project/src")) "/home/host/random/file.clj")
             :to-equal nil))
   (it "won't replace a prefix in the middle of the path"
-    (expect (cider--translate-docker "/src/project/src/ns.clj" '(("/src" . "/host")))
+    (expect (cider--translate-docker-test '(("/src" . "/host")) "/src/project/src/ns.clj")
             :to-equal "/host/project/src/ns.clj"))
   (it "ensures the prefix has a slash"
-    (expect (cider--translate-docker "/docker/ns.clj" '(("/docker" . "/host")))
-            :to-equal (cider--translate-docker "/docker/ns.clj" '(("/docker/" . "/host/"))))))
+    (expect (cider--translate-docker-test '(("/docker" . "/host")) "/docker/ns.clj")
+            :to-equal "/host/ns.clj")))