Merge pull request #172 from cichli/rename-value-slot

Rename `value` slot in `ns-list` and `ns-vars` responses

Author: bbatsov

src/cider/nrepl/middleware/ns.clj

@@ -43,12 +43,12 @@
 
 (defn ns-list-reply
   [{:keys [transport] :as msg}]
-  (transport/send transport (response-for msg :value (ns-list msg)))
+  (transport/send transport (response-for msg :ns-list (ns-list msg)))
   (transport/send transport (response-for msg :status :done)))
 
 (defn ns-vars-reply
   [{:keys [transport] :as msg}]
-  (transport/send transport (response-for msg :value (ns-vars msg)))
+  (transport/send transport (response-for msg :ns-vars (ns-vars msg)))
   (transport/send transport (response-for msg :status :done)))
 
 (defn wrap-ns

test/cider/nrepl/middleware/ns_test.clj

@@ -1,12 +1,27 @@
 (ns cider.nrepl.middleware.ns-test
-  (:require
-   [clojure.test :refer :all]
-   [cider.nrepl.middleware.test-transport :refer [messages test-transport]]
-   [cider.nrepl.middleware.ns :refer [ns-list-clj ns-vars-clj]]))
+  (:require [cider.nrepl.middleware.test-transport :refer [messages test-transport]]
+            [cider.nrepl.middleware.test-session :as session]
+            [cider.nrepl.middleware.ns :refer [ns-list-clj ns-vars-clj]]
+            [clojure.test :refer :all]))
 
 (deftest test-toogle-ns-list
   (is (= (count (all-ns)) (count (ns-list-clj)))))
 
 (deftest test-toogle-ns-vars
   (let [ns "clojure.core"]
     (is (= (count (ns-publics (symbol ns))) (count (ns-vars-clj ns))))))
+
+;; integration tests
+
+(use-fixtures :each session/session-fixture)
+
+(deftest ns-list-integration-test
+  (let [ns-list (:ns-list (session/message {:op "ns-list"}))]
+    (is (sequential? ns-list))
+    (is (every? string? ns-list))))
+
+(deftest ns-vars-integration-test
+  (let [ns-vars (:ns-vars (session/message {:op "ns-vars"
+                                            :ns "clojure.walk"}))]
+    (is (sequential? ns-vars))
+    (is (every? string? ns-vars))))