Rename module name to database name

[tamaro-skaljic]

Description of Changes

Fixes #2515

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

• Make sure that there are no other locations where it needs to be renamed.

Documentation

• search for with.*module.*name in the docs repository and replace any occurrences with with_database_name / withDatabaseName.

[gefjon]

Unfortunately, we can't make this change. DbConnectionBuilder::with_module_name is a part of our stable user-facing API, and so changing it would require a SemVer major version bump, which we're not willing to do at this time. We may discuss how to gradually transition to using with_database_name instead, but it's not something we can rush into.

[cloutiertyler]

This now LGTM

[cloutiertyler]

Retracting my approval. I was confused on PR numbers. We don't want to change the name of with_module_name at this time.

[tamaro-skaljic]

Unfortunately, we can't make this change. DbConnectionBuilder::with_module_name is a part of our stable user-facing API, and so changing it would require a SemVer major version bump, which we're not willing to do at this time. We may discuss how to gradually transition to using with_database_name instead, but it's not something we can rush into.

I've reworked it in 18624e5 so that no major version bump is needed.

I would say it's better to create the new default now and update the docs and example projects so that new users use the with_database_name method of the DBConnectionBuilder instead of the with_module_name method. Then they'll have one breaking change less to migrate if with_module_name is removed. If this is merged I'll create the PRs for the docs and example pprojects too. :)