Allow building custom standalone servers #2416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
added
the
community
m1guelpf
changed the title
ControlDb and members of StandaloneEnv struct
|
@jdetter lmk how I can go about signing the CLA |
|
@m1guelpf Could you send me an email to |
|
@m1guelpf We're happy to move forward with this. Just a note: While we guarantee API/ABI stability for future |
|
(also it looks like we have some merge conflicts now - if you can get those fixed, we should be good to go!) |
|
@bfops resolved the conflicts! crate stability is not an issue for me, I was planning to pin to a commit anyways 😁 |
|
Hey @m1guelpf - based on the test failures, it looks like some more crates need updating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Expands the
spacetimedb-standalonecrate to also serve as a library to build your own standalone servers with custom auth services and more. This is accomplished by:StandaloneEnvinstead of having to recreate it from scratch.StandaloneEnvabstract over anyJwtAuthProviderand not just the default (but still default toDefaultJwtAuthProvider, so no API changes for existing clients)API and ABI breaking changes
I don't believe this includes any breaking changes, other than some of the crate's API now being public. Since the crate is currently marked as unstable, this should be fine.
Expected complexity level and risk
Changes are very simple.
Testing
I'm using this branch locally to develop a custom SpacetimeDB server with stricter authentication requirements.