Panond to ckrening main #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added horizon model first draft * added get horizon function * fixing stickler items & updates * stickler whitespace * finishing up stickler * finishing up stickler, 2 * added optional deps, changed argument of horizon_map from path to array * stickler * Update pvlib/iotools/pvgis.py Co-authored-by: Karel De Brabandere <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * Update pvlib/horizon.py Co-authored-by: Cliff Hansen <[email protected]> * updates * cleaning up stickler * cleaning up stickler 2 * cleaning up stickler 3 * updated math for angle calculation * removed old comment * updated angle maximization method * one of these days I'll remember stickler before pushing * changed variable names to make clear that we're working in pixels * added module to download SRTM DEM data * spelling/spacing * stickler * stickler3 * fixed f string formatting stickler doesn't like it but it doesn't work with spaces * added horizon retrival, functions, dem retrival * stickler * stickler2 * stickler3 * Revert "merge2" This reverts commit 6f9ad5e, reversing changes made to 43951a2. * fix formatting * fix formatting, 2 * removing horizon.py * tests added * updated test * fixed stickler * minor formatting/stickler * Update v0.9.6.rst * Update iotools.rst * Apply suggestions from code review Co-authored-by: Kevin Anderson <[email protected]> * Change assert to use np builtin * correct docstring for hidden function * Chnage proxy settings to passing through kwargs * Changed proxy settings to pass kwargs * Change assertion to use assert_series_equal from conftest * Added horizon profile contributions * Update v0.9.6.rst * Delete cgiar.py * Delete test_cgiar.py * Update shading.py * Update setup.py * Update __init__.py * Update iotools.rst * Update test_pvgis.py * return only two columns and makde bytes->utf-8 implicit * Use JSON to streamline processing * Update pvgis.py * added url default info * remove np dependency * Apply suggestions from code review Co-authored-by: Adam R. Jensen <[email protected]> * Moved ref for consistency * Updated name of horizon data variable * Add CSV for horizon tests * Test whole dataframe * Change coordinate system to pvlib * fix test to read in csv properly * Apply suggestions from code review Co-authored-by: Adam R. Jensen <[email protected]> * Changed names for consistency * Match column names in test dataframe * stickler * Set horizon_azimuth to the index * Added invalid coords test * update test to reflect change to index * forgot xfail flag * Update test_read_pvgis_horzion_invalid_coords * return metadata object * Update pvgis.py * fix tests for metadata update * Remove index column from test file * Convert output to pd.Series * Update tests to assert pd.Series * Remove duplicate north value (0, 360) --------- Co-authored-by: Ben <[email protected]> Co-authored-by: Karel De Brabandere <[email protected]> Co-authored-by: Cliff Hansen <[email protected]> Co-authored-by: Pierce <[email protected]> Co-authored-by: Kevin Anderson <[email protected]> Co-authored-by: Adam R. Jensen <[email protected]>
* Change surface_azimuth convention * Update v0.9.6.rst * Update v0.9.6.rst * Update v0.9.6.rst * Update docs/sphinx/source/whatsnew/v0.9.6.rst Co-authored-by: Kevin Anderson <[email protected]> * Remote info section header * Add version changed * Update version changed * Update pvlib/iotools/pvgis.py Co-authored-by: Kevin Anderson <[email protected]> * Add azimuth warning section * Add Warning to read_pvgis_hourly * Remove surface_azimuth hint * Update read_pvgis_hourly warning --------- Co-authored-by: Kevin Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.