autoApprove is false by default, and model will now tell user the CLI command to approve tasks

Author: chriscarrollsmith

.cursor/rules/general.mdc

@@ -3,4 +3,6 @@ description:
 globs: 
 alwaysApply: true
 ---
-Work step-by-step. If presented with an implementation plan, implement the plan exactly. If the plan presents more than one implementation option, consult with the human user to decide between options. If you are tempted to embellish or imporve upon the plan, consult with the human user. Always complete the current task and wait for human review before proceeding to the next task.
+Work step-by-step. If presented with an implementation plan, implement the plan exactly. If the plan presents more than one implementation option, consult with the human user to decide between options. If you are tempted to embellish or imporve upon the plan, consult with the human user. Always complete the current task and wait for human review before proceeding to the next task.
+
+In developing this codebase, we are doing test-driven development with an integration testing (as opposed to a unit testing) verification strategy. Before writing any code (except perhaps for empty function or class signatures), we will write tests and run them to make sure they fail. The red phase is not complete until the tests are failing correctly.

.cursor/rules/tests.mdc

@@ -3,4 +3,4 @@ description: Writing unit tests with `jest`
 globs: tests/**/*
 alwaysApply: false
 ---
-Make use of the helpers in tests/mcp/test-helpers.ts.
+Make use of the helpers in tests/mcp/test-helpers.ts for writing tests.

package-lock.json

@@ -1,6 +1,6 @@
 {
 	"name": "taskqueue-mcp",
-	"version": "1.4.0",
+	"version": "1.4.1",
 	"description": "Task Queue MCP Server",
 	"author": "Christopher C. Smith ([email protected])",
 	"main": "dist/src/server/index.js",

package.json

@@ -14,7 +14,7 @@ const program = new Command();
 program
   .name("taskqueue")
   .description("CLI for the Task Manager MCP Server")
-  .version("1.4.0")
+  .version("1.4.1")
   .option(
     '-f, --file-path <path>',
     'Specify the path to the tasks JSON file. Overrides TASK_MANAGER_FILE_PATH env var.'

src/client/cli.ts

@@ -15,6 +15,7 @@ import {
   AddTasksSuccessData,
   DeleteTaskSuccessData,
   ReadProjectSuccessData,
+  UpdateTaskSuccessData
 } from "../types/response.js";
 import { AppError, AppErrorCode } from "../types/errors.js";
 import { FileSystemService } from "./FileSystemService.js";
@@ -519,7 +520,7 @@ export class TaskManager {
       status?: "not started" | "in progress" | "done";
       completedDetails?: string;
     }
-  ): Promise<Task> {
+  ): Promise<UpdateTaskSuccessData> {
     await this.ensureInitialized();
     await this.reloadFromDisk();
 
@@ -544,8 +545,14 @@ export class TaskManager {
     // Apply updates
     Object.assign(task, updates);
 
+    // Generate message if needed
+    let message: string | undefined = undefined;
+    if (updates.status === 'done' && proj.autoApprove === false) {
+      message = `Task marked as done but requires approval.\nTo approve, run: npx taskqueue approve-task -- ${projectId} ${taskId}`;
+    }
+
     await this.saveTasks();
-    return task;
+    return { task, message };
   }
 
   public async deleteTask(projectId: string, taskId: string): Promise<DeleteTaskSuccessData> {

src/server/TaskManager.ts

@@ -10,7 +10,7 @@ import { ListToolsRequestSchema, CallToolRequestSchema } from "@modelcontextprot
 const server = new Server(
   {
     name: "task-manager-server",
-    version: "1.4.0"
+    version: "1.4.1"
   },
   {
     capabilities: {

src/server/index.ts

@@ -3,6 +3,7 @@ import { TaskManager } from "./TaskManager.js";
 import { toolExecutorMap } from "./toolExecutors.js";
 import { AppError, AppErrorCode } from "../types/errors.js";
 import { McpError, CallToolResult, ErrorCode } from "@modelcontextprotocol/sdk/types.js";
+import { UpdateTaskSuccessData } from '../types/response.js';
 
 // ---------------------- PROJECT TOOLS ----------------------
 
@@ -468,9 +469,11 @@ export async function executeToolAndHandleErrors(
     // 2. Execute the tool - Validation errors (protocol) or TaskManager errors (execution) might be thrown
     const resultData = await executor.execute(taskManager, args);
 
-    // 3. Format successful execution result
+    // 3. Format successful execution result using standard stringify
+    const responseText = JSON.stringify(resultData, null, 2);
+
     return {
-      content: [{ type: "text", text: JSON.stringify(resultData, null, 2) }]
+      content: [{ type: "text", text: responseText }]
     };
 
   } catch (error: AppError | unknown) {

src/server/tools.ts

@@ -55,7 +55,7 @@ export interface ProjectCreationSuccessData {
   export interface DeleteTaskSuccessData {
     message: string;
   }
-  
+
   export interface ReadProjectSuccessData {
     projectId: string;
     initialPrompt: string;
@@ -64,4 +64,10 @@ export interface ProjectCreationSuccessData {
     autoApprove?: boolean;
     tasks: Task[];
   }
+
+  // Add the new interface for update_task success
+  export interface UpdateTaskSuccessData {
+    task: Task; // The updated task object
+    message?: string; // Optional message (e.g., approval reminder)
+  }
 

src/types/response.ts

@@ -111,6 +111,7 @@ describe('create_project Tool', () => {
         "Task 2",
         "Task 3"
       ]);
+      expect(project).toHaveProperty('autoApprove', false);
     });
 
     it('should create a project with auto-approve enabled', async () => {