text [nfc]: Pull out kDefaultFontFamily constant

Author: chrisbobbe

lib/widgets/content.dart

@@ -99,7 +99,7 @@ class Paragraph extends StatelessWidget {
   final ParagraphNode node;
 
   static TextStyle getTextStyle(BuildContext context) => const TextStyle(
-    fontFamily: 'Source Sans 3',
+    fontFamily: kDefaultFontFamily,
     fontSize: 14,
     height: (17 / 14),
   ).merge(weightVariableTextStyle(context));

lib/widgets/emoji_reaction.dart

@@ -174,7 +174,7 @@ class ReactionChip extends StatelessWidget {
                           textWidthBasis: TextWidthBasis.longestLine,
                           textScaler: _labelTextScalerClamped(context),
                           style: TextStyle(
-                            fontFamily: 'Source Sans 3',
+                            fontFamily: kDefaultFontFamily,
                             fontSize: (14 * 0.90),
                             height: 13 / (14 * 0.90),
                             color: labelColor,
@@ -352,7 +352,7 @@ class _TextEmoji extends StatelessWidget {
       textAlign: TextAlign.end,
       textScaler: _textEmojiScalerClamped(context),
       style: TextStyle(
-        fontFamily: 'Source Sans 3',
+        fontFamily: kDefaultFontFamily,
         fontSize: 14 * 0.8,
         height: 1, // to be denser when we have to wrap
         color: selected ? _textColorSelected : _textColorUnselected,

lib/widgets/inbox.dart

@@ -240,7 +240,7 @@ abstract class _HeaderItem extends StatelessWidget {
             padding: const EdgeInsets.symmetric(vertical: 4),
             child: Text(
               style: const TextStyle(
-                fontFamily: 'Source Sans 3',
+                fontFamily: kDefaultFontFamily,
                 fontSize: 17,
                 height: (20 / 17),
                 color: Color(0xFF222222),
@@ -361,7 +361,7 @@ class _DmItem extends StatelessWidget {
                 padding: const EdgeInsets.symmetric(vertical: 4),
                 child: Text(
                   style: const TextStyle(
-                    fontFamily: 'Source Sans 3',
+                    fontFamily: kDefaultFontFamily,
                     fontSize: 17,
                     height: (20 / 17),
                     color: Color(0xFF222222),
@@ -487,7 +487,7 @@ class _TopicItem extends StatelessWidget {
                 padding: const EdgeInsets.symmetric(vertical: 4),
                 child: Text(
                   style: const TextStyle(
-                    fontFamily: 'Source Sans 3',
+                    fontFamily: kDefaultFontFamily,
                     fontSize: 17,
                     height: (20 / 17),
                     color: Color(0xFF222222),

lib/widgets/message_list.dart

@@ -436,7 +436,7 @@ class MarkAsReadWidget extends StatelessWidget {
               backgroundColor: _UnreadMarker.color,
               minimumSize: const Size.fromHeight(38),
               textStyle: const TextStyle(
-                fontFamily: 'Source Sans 3',
+                fontFamily: kDefaultFontFamily,
                 fontSize: 18,
                 height: (23 / 18),
               ).merge(weightVariableTextStyle(context)),
@@ -573,7 +573,7 @@ class StreamMessageRecipientHeader extends StatelessWidget {
     }
     final textStyle = TextStyle(
       color: contrastingColor,
-      fontFamily: 'Source Sans 3',
+      fontFamily: kDefaultFontFamily,
       fontSize: 16,
       letterSpacing: 0.02 * 16,
       height: (18 / 16),
@@ -684,7 +684,7 @@ class DmRecipientHeader extends StatelessWidget {
               Expanded(
                 child: Text(title,
                   style: const TextStyle(
-                    fontFamily: 'Source Sans 3',
+                    fontFamily: kDefaultFontFamily,
                     fontSize: 16,
                     letterSpacing: 0.02 * 16,
                     height: (18 / 16),
@@ -716,7 +716,7 @@ class RecipientHeaderDate extends StatelessWidget {
       child: Text(
         style: TextStyle(
           color: color,
-          fontFamily: 'Source Sans 3',
+          fontFamily: kDefaultFontFamily,
           fontSize: 16,
           // In Figma this has a line-height of 19, but using 18
           // here to match the stream/topic text widgets helps

lib/widgets/recent_dm_conversations.dart

@@ -127,7 +127,7 @@ class RecentDmConversationsItem extends StatelessWidget {
               padding: const EdgeInsets.symmetric(vertical: 4),
               child: Text(
                 style: const TextStyle(
-                  fontFamily: 'Source Sans 3',
+                  fontFamily: kDefaultFontFamily,
                   fontSize: 17,
                   height: (20 / 17),
                   color: Color(0xFF222222),

lib/widgets/subscription_list.dart

@@ -119,7 +119,7 @@ class _NoSubscriptionsItem extends StatelessWidget {
           textAlign: TextAlign.center,
           style: TextStyle(
             color: const HSLColor.fromAHSL(1.0, 240, 0.1, 0.5).toColor(),
-            fontFamily: 'Source Sans 3',
+            fontFamily: kDefaultFontFamily,
             fontSize: 18,
             height: (20 / 18),
           ).merge(weightVariableTextStyle(context)))));
@@ -148,7 +148,7 @@ class _SubscriptionListHeader extends StatelessWidget {
                 textAlign: TextAlign.center,
                 style: TextStyle(
                   color: const HSLColor.fromAHSL(1.0, 240, 0.1, 0.5).toColor(),
-                  fontFamily: 'Source Sans 3',
+                  fontFamily: kDefaultFontFamily,
                   fontSize: 14,
                   letterSpacing: 0.04 * 14,
                   height: (16 / 14),
@@ -220,7 +220,7 @@ class SubscriptionItem extends StatelessWidget {
               //   https://github.com/zulip/zulip-flutter/pull/397#pullrequestreview-1742524205
               child: Text(
                 style: const TextStyle(
-                  fontFamily: 'Source Sans 3',
+                  fontFamily: kDefaultFontFamily,
                   fontSize: 18,
                   height: (20 / 18),
                   color: Color(0xFF262626),

lib/widgets/text.dart

@@ -2,6 +2,12 @@ import 'dart:io';
 import 'dart:ui';
 import 'package:flutter/widgets.dart';
 
+/// The [TextStyle.fontFamily] to use in most of the app.
+///
+/// This is a variable-weight font, so any [TextStyle] that uses this should be
+/// merged with the result of calling [weightVariableTextStyle].
+const kDefaultFontFamily = 'Source Sans 3';
+
 /// A mergeable [TextStyle] with 'Source Code Pro' and platform-aware fallbacks.
 ///
 /// Callers should also call [weightVariableTextStyle] and merge that in too,

lib/widgets/unread_count_badge.dart

@@ -45,7 +45,7 @@ class UnreadCountBadge extends StatelessWidget {
         padding: const EdgeInsets.fromLTRB(4, 0, 4, 1),
         child: Text(
           style: const TextStyle(
-            fontFamily: 'Source Sans 3',
+            fontFamily: kDefaultFontFamily,
             fontSize: 16,
             height: (18 / 16),
             fontFeatures: [FontFeature.enable('smcp')], // small caps