Merge pull request #384 from IHIutch/update-collapse

codebender828 · web-flow · commit 58daec47b519 · 2021-02-07T16:30:34.000+08:00
fix: Set ccollapse height to auto on enter complete, unless finalHeight wa…
diff --git a/packages/chakra-ui-core/src/CAccordion/CAccordion.stories.js b/packages/chakra-ui-core/src/CAccordion/CAccordion.stories.js
@@ -32,6 +32,7 @@ storiesOf('UI | Accordion', module)
           tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
           veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea
           commodo consequat.
+        </CAccordionPanel>
       </CAccordionItem>
     </CAccordion>
     `
diff --git a/packages/chakra-ui-core/src/CTransition/Transition.js b/packages/chakra-ui-core/src/CTransition/Transition.js
@@ -486,7 +486,7 @@ const CAnimateHeight = {
           height: [this.initialHeight || 0, this.finalHeight || height],
           easing: this.enterEasing,
           duration: this.duration,
-          complete
+          complete: () => { el.style.height = this.finalHeight || 'auto' }
         })
       })
     },

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ storiesOf('UI \| Accordion', module)`
`32`	`32`	`tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim`
`33`	`33`	`veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea`
`34`	`34`	`commodo consequat.`
	`35`	`+ </CAccordionPanel>`
`35`	`36`	`</CAccordionItem>`
`36`	`37`	`</CAccordion>`
`37`	`38`	`