Skip to content

docs: builds readthedocs #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ioannistsanaktsidis
Copy link
Member

Signed-off-by: Ioannis Tsanaktsidis [email protected]

@coveralls
Copy link

coveralls commented Jul 9, 2018

Coverage Status

Coverage remained the same at 5.735% when pulling d1111b6 on ioannistsanaktsidis:docs-build into ea92265 on cernanalysispreservation:master.

@@ -42,7 +42,7 @@ CAP-client
-------------

The CAP-client is a command-line tool for preserving analyses.
It is implemented as a python package and its documentation can be found `here <https://cap-client.readthedocs.io>`_.
It is implemented as a python package and its documentation can be found `here <https://cap-client.readthedocs.io>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be only one trailing _ in reST links....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm, not sure about that, if I have it only one is failing with this error
sphinx-doc/sphinx#3921

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiborsimko ok you are right, was failing when I tried to build it locally but seems that it is not an issue. I updated the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, if the link target is the same, you can define it once and use it multiple times like:


This is `foo`_ and...

As we said there is also `foo`_ that you can take advantage of ...

Yet another paragraph where we mention `foo`_ because...

.. _foo: http://example.org

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh cool, didnt know that, will update !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But actually the links are different so it shouldnt be an issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case we shouldn't really call them both "here":

$ rm -rf docs/_build/
$ python setup.py build_sphinx
[...]
docs/tutorials.rst:2: WARNING: Duplicate explicit target name: "here".

Better give them different names...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool! Updated!

REANA is a reusable and reproducible research data analysis platform. It helps researchers to structure their input data, analysis code, containerised environments and computational workflows so that the analysis can be instantiated and run on remote compute clouds. REANA was born to target the use case of particle physics analyses, but is applicable to any scientific discipline. The system paves the way towards reusing and reinterpreting preserved data analyses even several years after the original publication. Find comprehensive documentation about the REANA project `here <https://reana.readthedocs.io/en/latest/>`__.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here, only one trailing _.

@ioannistsanaktsidis ioannistsanaktsidis force-pushed the docs-build branch 2 times, most recently from 224c8a3 to 98542f6 Compare July 9, 2018 13:55
Signed-off-by: Ioannis Tsanaktsidis <[email protected]>
@tiborsimko tiborsimko merged commit d1111b6 into cernanalysispreservation:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants