bug(fcsfile): fix recursion when file has no spill string #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gegnew
force-pushed
the
ge/hotfix-spillstring
branch
from
b91ee61 to
1f8ac87
Compare
gegnew
changed the title
gingo00
reviewed
Feb 15, 2022
There was a problem hiding this comment.
I confirm that it does fix the recursive call issue.
Possibly, like Zach suggested in slack, the get_file_internal_compensation method could verify the hasFileInternalComp attribute and throw a more meaningful error (or return None) if hasFileInternalComp is false. Otherwise, the user get a more cryptic ValueError: invalid literal for int() with base 10: '' from the Compensation.from_spill_string method.
gegnew
force-pushed
the
ge/hotfix-spillstring
branch
from
1f8ac87 to
52c354f
Compare
|
☝️ implemented |
|
This also accounts for the edge case (which I think only happens in my tests) where |
zbjornson
reviewed
Feb 16, 2022
gegnew
force-pushed
the
ge/hotfix-spillstring
branch
4 times, most recently
from
c70c92a to
cdd49ee
Compare
zbjornson
reviewed
Feb 28, 2022
|
@gegnew you requested review but I don't see a new push. |
gegnew
force-pushed
the
ge/hotfix-spillstring
branch
from
cdd49ee to
5b8edb5
Compare
|
🤦 sorry, forgot to push it after fixing merge conflicts |
gegnew
force-pushed
the
ge/hotfix-spillstring
branch
from
5b8edb5 to
d766bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation will change with #136 and the PRs that follow