-
Notifications
You must be signed in to change notification settings - Fork 1
feat(apiclient, gate): Add apply_tailoring function #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d41f4d
to
24fd433
Compare
3d6d026
to
b8edb2a
Compare
Depends on #136 |
24fd433
to
57715d6
Compare
I think CE will apply gates only if the gate provided is different than the currently set gate for this sample for this gate group. By different, I mean a different position (gate model), not different in terms of "_id". So to get this response, I assume that the gate model provided was the same as the one currently applied to the files you tried and therefore, CE did nothing. |
57715d6
to
a7907fe
Compare
e84a6f2
to
5c13a23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with different gates to get some inserted/updated/deleted return values and that worked well. See comments about **kwargs
897da28
to
e8212b6
Compare
a7907fe
to
d5b5457
Compare
4128181
to
7199a93
Compare
ac6f89a
to
4e844c3
Compare
06548af
to
d7ba26a
Compare
Instead of requesting gates in a loop, per #140 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, just nits left.
I'll get back to ge/cattrs-gates this week finally.
Instead of requesting gates in a loop, per #140 (comment)
Instead of requesting gates in a loop, per #140 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Will merge once the upstream branch is settled.
158ce7f
to
de34f53
Compare
c4df360
to
7c59370
Compare
021c939
to
33d89be
Compare
|
Fixes #121
I couldn't seem to get CE to actually apply gates to any files, so the only live response I received was:
I'm pretty sure that I tested this on the appropriate object, based on the function def in
cellengine/app/controllers/gates.server.controller.mjs
, but it merits a second set of 👀Particularly, I used:
and a variation of that with multiple objects in the "updated" array.