Skip to content

src(comp): Use cattrs #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2021
Merged

src(comp): Use cattrs #137

merged 1 commit into from
Dec 23, 2021

Conversation

gegnew
Copy link
Contributor

@gegnew gegnew commented Dec 14, 2021 •
edited
Loading

  • src(comp): Use attrs + cattrs

Depends on #133

@gegnew gegnew changed the base branch from master to ge/cattrs2 December 14, 2021 14:30
@gegnew gegnew requested a review from zbjornson December 14, 2021 14:30
zbjornson
zbjornson reviewed Dec 14, 2021
View reviewed changes
@gegnew gegnew force-pushed the ge/cattrs2 branch 5 times, most recently from 46b80e8 to 2d35c99 Compare December 15, 2021 21:49
@gegnew gegnew requested a review from zbjornson December 15, 2021 22:13
zbjornson
zbjornson approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One line I think can be deleted sometime, but won't hold this PR up anymore.

@gegnew gegnew force-pushed the ge/cattrs2 branch 4 times, most recently from d77f707 to 17580e9 Compare December 17, 2021 07:47
@gegnew gegnew force-pushed the ge/cattrs-comp branch 2 times, most recently from c91c325 to aebf24d Compare December 20, 2021 11:52
@gegnew gegnew requested a review from zbjornson December 20, 2021 11:58
Base automatically changed from ge/cattrs2 to master December 23, 2021 17:56
zbjornson
zbjornson approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Just rebased.

@zbjornson zbjornson merged commit 7341d0d into master Dec 23, 2021
@zbjornson zbjornson deleted the ge/cattrs-comp branch December 23, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbjornson zbjornson zbjornson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gegnew @zbjornson