Skip to content

bug(gates): fix create_population argument handling #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

zbjornson
Copy link
Member

@zbjornson zbjornson commented Dec 13, 2021

Fixes #118


Depends on #128 (base branch)
Can be superseded by #112 if it's updated per comments there.

Affects plots and anything else where CellEngine's API is case-sensitive (might only be plots). We'll make the API case-insensitive at some point soon as well.

Fixes #124
@gegnew
Copy link
Contributor

gegnew commented Dec 14, 2021

I've made the corresponding changes in #136 , which will also depend on #128

Base automatically changed from zb/124 to master December 14, 2021 16:29
@zbjornson
Copy link
Member Author

Great, and I see you copied the test over 👍 .

@zbjornson zbjornson closed this Dec 14, 2021
@zbjornson zbjornson deleted the zb/118 branch December 14, 2021 16:30
@zbjornson zbjornson restored the zb/118 branch December 22, 2021 02:18
@zbjornson zbjornson deleted the zb/118 branch September 21, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gate creation from experiment resource ignores the create_population parameter
2 participants