[WIP] fix fleeting plugin installation for docker autoscaler #1260
+33
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @daveaie! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
kayman-mk
requested changes
Mar 12, 2025
|
|
||
| capacity_per_instance = ${runners_capacity_per_instance} | ||
| update_interval = "${runners_update_interval}" | ||
| update_interval_when_expecting = "${runners_update_interval_when_expecting}" | ||
|
|
||
| delete_instances_on_shutdown = ${delete_instances_on_shutdown} |
There was a problem hiding this comment.
thought: does this make our Lambda function superfluous? We have it to kill the instances on shutdown of the agent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello everyone,
i have pushed 3 improvement to use docker autoscaler gitlub runner:
Migrations required
No migration required.
Verification
I'm using my version of this module in our gitlab on premise installation since a week.
The reason I implemented this fix is that with the old installation method of the fleeting plugin, the runners did not scale down correctly as indicated in this issue