Skip to content

Commit 41058c8

Browse files
chore!: remove declaration of unused variables for docker-autoscaler setup (#1223)
# Description This PR removes the declaration of some settings of `var.runner_worker_docker_autoscaler_asg` that are never used in the terraform manifests of the module. --------- Signed-off-by: Yevgen Karlashov <[email protected]> Co-authored-by: Matthias Kay <[email protected]>
1 parent a197e4f commit 41058c8

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

examples/runner-fleeting-plugin/main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ module "runner" {
104104
enable_mixed_instances_policy = true
105105
on_demand_base_capacity = 1
106106
on_demand_percentage_above_base_capacity = 0
107-
max_growth_rate = 10
108107
}
109108

110109
runner_worker_docker_autoscaler_autoscaling_options = [

variables.tf

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -731,11 +731,8 @@ variable "runner_worker_docker_autoscaler_asg" {
731731
health_check_type = Controls how health checking is done. Values are - EC2 and ELB.
732732
instance_refresh_min_healthy_percentage = The amount of capacity in the Auto Scaling group that must remain healthy during an instance refresh to allow the operation to continue, as a percentage of the desired capacity of the Auto Scaling group.
733733
instance_refresh_triggers = Set of additional property names that will trigger an Instance Refresh. A refresh will always be triggered by a change in any of launch_configuration, launch_template, or mixed_instances_policy.
734-
max_growth_rate = The maximum number of machines that can be added to the runner in parallel.
735734
on_demand_base_capacity = Absolute minimum amount of desired capacity that must be fulfilled by on-demand instances.
736735
on_demand_percentage_above_base_capacity = Percentage split between on-demand and Spot instances above the base on-demand capacity.
737-
override_instance_types = List to override the instance type in the Launch Template. Allow to spread spot instances on several types, to reduce interruptions.
738-
profile_name = profile_name = Name of the IAM profile to attach to the Runner Workers.
739736
spot_allocation_strategy = How to allocate capacity across the Spot pools. 'lowest-price' to optimize cost, 'capacity-optimized' to reduce interruptions.
740737
spot_instance_pools = Number of Spot pools per availability zone to allocate capacity. EC2 Auto Scaling selects the cheapest Spot pools and evenly allocates Spot capacity across the number of Spot pools that you specify.
741738
subnet_ids = The list of subnet IDs to use for the Runner Worker when the fleet mode is enabled.
@@ -749,10 +746,8 @@ variable "runner_worker_docker_autoscaler_asg" {
749746
health_check_type = optional(string, "EC2")
750747
instance_refresh_min_healthy_percentage = optional(number, 90)
751748
instance_refresh_triggers = optional(list(string), [])
752-
max_growth_rate = optional(number, 0)
753749
on_demand_base_capacity = optional(number, 0)
754750
on_demand_percentage_above_base_capacity = optional(number, 100)
755-
profile_name = optional(string, "")
756751
spot_allocation_strategy = optional(string, "lowest-price")
757752
spot_instance_pools = optional(number, 2)
758753
subnet_ids = optional(list(string), [])

0 commit comments

Comments
 (0)