fix: NPE on shutdown

stuartwdouglas · svc-squareup-copybara · commit 1b1f8035c5bb · 2025-09-15T20:10:28.000Z
If the cluster weight is zero we don't add oursevles to the table,
shutdown was not accounting for this.

GitOrigin-RevId: f4912d72993e15de066459150e23c7438ad62718
diff --git a/misk-clustering-dynamodb/src/main/kotlin/misk/clustering/dynamo/DynamoClusterWatcherTask.kt b/misk-clustering-dynamodb/src/main/kotlin/misk/clustering/dynamo/DynamoClusterWatcherTask.kt
@@ -106,7 +106,9 @@ internal class DynamoClusterWatcherTask @Inject constructor(
         .partitionValue(self)
         .build()
     )
-    table.deleteItem(member)
+    if (member != null) {
+      table.deleteItem(member)
+    }
   }
 
   companion object {

Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,9 @@ internal class DynamoClusterWatcherTask @Inject constructor(`
`106`	`106`	`.partitionValue(self)`
`107`	`107`	`.build()`
`108`	`108`	`)`
`109`		`- table.deleteItem(member)`
	`109`	`+ if (member != null) {`
	`110`	`+ table.deleteItem(member)`
	`111`	`+ }`
`110`	`112`	`}`
`111`	`113`
`112`	`114`	`companion object {`