fix(notification): add aria label and description #3145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Akshat55
requested changes
May 21, 2025
| @@ -83,6 +83,8 @@ export class ActionableNotification extends BaseNotification { | |||
| } | |||
|
|
|||
| @HostBinding("attr.id") notificationID = `notification-${ActionableNotification.notificationCount++}`; | |||
| @HostBinding("attr.aria-label") notificationLabel = `Notification`; | |||
| @HostBinding("attr.aria-describedby") notificationDescription = `${this.notificationObj.type} notification`; | |||
There was a problem hiding this comment.
aria-describedby attribute usually references an ID not text.
There was a problem hiding this comment.
Changed it to the text Notification-ID
Akshat55
requested changes
May 23, 2025
Comment on lines
+85
to
+87
| @HostBinding("attr.id") notificationID = `notification-${ActionableNotification.notificationCount}`; | ||
| @HostBinding("attr.aria-label") notificationLabel = `Notification`; | ||
| @HostBinding("attr.aria-describedby") notificationDescription = `Notification-${ActionableNotification.notificationCount++}`; |
There was a problem hiding this comment.
Suggested change
| @HostBinding("attr.id") notificationID = `notification-${ActionableNotification.notificationCount}`; | |
| @HostBinding("attr.aria-label") notificationLabel = `Notification`; | |
| @HostBinding("attr.aria-describedby") notificationDescription = `Notification-${ActionableNotification.notificationCount++}`; | |
| notificationID = `notification-${ActionableNotification.notificationCount++}`; | |
| @HostBinding("attr.aria-labelledby") labelledby= `Notification-${this.notificationID}`; // May need to use a getter, double check. |
Update the code to use aria-labelledBy, you can remove aria-label. The ID should be assigned to the following element (title):
<div *ngIf="!notificationObj.template" cdsActionableTitle [innerHTML]="notificationObj.title"></div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3144
Added
aria-labelandaria-describedbyto notification element