Skip to content

fix(modal): refactor modalService.show and add interfaces #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018

Conversation

cal-smith
Copy link
Contributor

closes #151
fixes #158

Copy link
Member

@zvonimirfras zvonimirfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please! 🎉

@zvonimirfras zvonimirfras merged commit b8b6153 into carbon-design-system:master Oct 12, 2018
@carbon-bot
Copy link
Contributor

🎉 This PR is included in version 1.8.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run storybook due to Typescript error in Terminal Add modal button interface
3 participants