Remove hardcoded path (BugFix) (#2040)

* Remove hardcoded path

* Removed hardcoded paths in software raid

* using pathlib open function

Author: fernando79513

providers/base/tests/test_check_software_raid.py

@@ -2,15 +2,17 @@
 import unittest
 from unittest.mock import patch
 import check_software_raid
+import pathlib
 
 
 class TestCheckSoftwareRAID(unittest.TestCase):
 
     def test_get_md_stat_intel_raid(self):
 
         expected_data = [{"device": "md126", "mode": "raid0"}]
+        test_dir = pathlib.Path(__file__).parent / "test_data"
         raid_data = check_software_raid.get_md_stat(
-            "tests/test_data/mdstat_intel_rst.txt"
+            test_dir / "mdstat_intel_rst.txt"
         )
         self.assertListEqual(raid_data, expected_data)
 
@@ -20,15 +22,16 @@ def test_get_md_stat_multiple_raid(self):
             {"device": "md2", "mode": "raid1"},
             {"device": "md1", "mode": "raid0"},
         ]
+        test_dir = pathlib.Path(__file__).parent / "test_data"
         raid_data = check_software_raid.get_md_stat(
-            "tests/test_data/mdstat_multiple_raid.txt"
+            test_dir / "mdstat_multiple_raid.txt"
         )
         self.assertListEqual(raid_data, expected_data)
 
     def test_get_md_stat_empty(self):
-
+        test_dir = pathlib.Path(__file__).parent / "test_data"
         raid_data = check_software_raid.get_md_stat(
-            "tests/test_data/mdstat_none_raid.txt"
+            test_dir / "mdstat_none_raid.txt"
         )
         self.assertListEqual(raid_data, [])
 

providers/base/tests/test_gl_support.py

@@ -18,6 +18,7 @@
 from gl_support import *
 from unittest.mock import patch, MagicMock
 import unittest
+import pathlib
 
 
 class RemoveColorCode(unittest.TestCase):
@@ -28,16 +29,17 @@ class RemoveColorCode(unittest.TestCase):
     @patch("subprocess.run")
     def test_succ(self, mock_run):
         gs = GLSupport()
+        test_dir = pathlib.Path(__file__).parent / "test_data"
 
-        SUCC = "tests/test_data/gl_support_succ.txt"
-        SUCC_CHANGED = "tests/test_data/gl_support_succ_changed.txt"
-        FAIL = "tests/test_data/gl_support_fail.txt"
-        FAIL_CHANGED = "tests/test_data/gl_support_fail_changed.txt"
-        with open(SUCC, "r") as s, open(SUCC_CHANGED, "r") as sc:
+        SUCC = test_dir / "gl_support_succ.txt"
+        SUCC_CHANGED = test_dir / "gl_support_succ_changed.txt"
+        FAIL = test_dir / "gl_support_fail.txt"
+        FAIL_CHANGED = test_dir / "gl_support_fail_changed.txt"
+        with SUCC.open() as s, SUCC_CHANGED.open() as sc:
             rv = gs.remove_color_code(s.read())
             self.assertEqual(rv, sc.read())
 
-        with open(FAIL, "r") as f, open(FAIL_CHANGED, "r") as fc:
+        with FAIL.open() as f, FAIL_CHANGED.open() as fc:
             rv = gs.remove_color_code(f.read())
             self.assertEqual(rv, fc.read())