fix: add React.Fragment support for matching text

[lachiet]

Summary

When using getByText() on a custom component using nested Fragments, it should return the text content within the fragments.

const CustomText = () => {
  return <React.Fragment>Hello World</React.Fragment>;
};

<Text>
  <CustomText />
</Text>

Test plan

I've added an additional test and all other tests are passing. Let me know if there's any concerns or other things we can add to protect against regression.

[thymikee]

Thanks for this improvement! What if, instead, we adjust the getChildrenAsText to detect Text with an array of strings?

[lachiet]

Thanks for this improvement! What if, instead, we adjust the getChildrenAsText to detect Text with an array of strings?

@thymikee no problem! I initially tried that approach but it seems like I can't access the children or props.children from the child object? This is what I get when I console.log(child) out before this line - any ideas?

{
  '$$typeof': Symbol(react.element),
  type: [Function: CustomText],
  key: null,
  ref: null,
  props: {},
  _owner: null,
   _store: {}
}

[thymikee]

checking parents non-recursively will result in a failure in e.g. this scenario:

const Wrap = ({ children }) => <>{children}</>;

  const CustomText = () => {
    return <React.Fragment>Hello World</React.Fragment>;
  };

  expect(
    render(
      <Text>
        <Wrap>
          <CustomText />
        </Wrap>
      </Text>
    ).queryByText('Hello World')
  ).toBeTruthy();

[thymikee]

Please check this PR as well: #554 as it's changing the way we're interfacing text to be similar to React Testing Library. Grabbing by text with non-direct string children is tricky and we'll likely need to trade-off some functionality, or come up with a more complex solution.

We want to solve this problem once for good, so if you're willing to help improve the library, please chime in there and see how we can support this scenario with string precision API

[thymikee]

FYI, #554 is now merged. Would you be still interested in pursuing this improvement? 😊

[thymikee]

Closed via #934