-
Notifications
You must be signed in to change notification settings - Fork 173
towards #35 #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
towards #35 #63
Conversation
I don't think we want to check unsupported shells though. https://github.com/koalaman/shellcheck/blob/cfd68ee0c2ebfd0ab08a1d4bf628162b454dc207/src/ShellCheck/Parser.hs#L3236 |
goodShells = [
"sh",
"ash",
"dash",
"bash",
"bats",
"ksh"
]
badShells = [
"awk",
"csh",
"expect",
"perl",
"python",
"ruby",
"tcsh",
"zsh"
] |
The problem will be I was wrong:
So we need to get those good shells upstreamed as extension (except |
Do not merge before pre-commit/identify#129 landed in a release which is then acctually used here. |
Co-authored-by: Robert Hensing <[email protected]>
identify now just needs a bump in nixpkgs |
Going to fix as part of #65 that will include the bump. |
#35
Do not merge before pre-commit/identify#129 landed in a release which is then acctually used here.