Let shellcheck handle good vs bad shell types #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches official shellcheck pre-commit hook at [1]. This works because shellcheck will silently skip "badShells" so there isn't a good reason to do this here. The old setup was actually causing pre-commit to skip shell scripts ending with .sh since both types *and* types_or were specified but the identified tags resulted in an empty set: $ cat t.sh echo hi $ nix-shell -p python3Packages.identify --run 'identify-cli t.sh' ["file", "non-executable", "shell", "text"] An argument could be had that 'sh' should have shown up due to the extension similar to other shells but I still believe we should merge this and match upstream. 1: https://github.com/koalaman/shellcheck-precommit/blob/v0.9.0/.pre-commit-hooks.yaml#L7
|
Originally introduced in #35 |
|
Pinging @domenkozar |
This is a life saver! Thank you for finding this out! Sounds good to me. |
roberth
approved these changes
Aug 16, 2023
|
Thank you! |
|
NP 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches official shellcheck pre-commit hook1. This works because shellcheck will silently skip "badShells" so there isn't a good reason to do this here. The old setup was actually causing pre-commit to skip shell scripts ending with .sh since both
typesandtypes_orwere specified but the identified tags resulted in an empty set sinceshellis not intypes_or, nor isshreturned from identification:An argument could be had that 'sh' should have shown up due to the extension similar to other shells but I still believe we should merge this and match upstream.