Skip to content

diverging pre-commit versions #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blaggacao opened this issue Sep 3, 2020 · 2 comments
Closed

diverging pre-commit versions #59

blaggacao opened this issue Sep 3, 2020 · 2 comments

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Sep 3, 2020 •
edited
Loading

https://github.com/cachix/pre-commit-hooks.nix/blob/a3f7609ba73eb9ce3fe434d4339101017a430912/nix/packages.nix#L8

It looks to me as if this attribute would not represent the cfg.package package version — if specified.
@blaggacao blaggacao changed the title divergin pre-commit versions diverging pre-commit versions Sep 3, 2020
@roberth
Copy link
Contributor

roberth commented Sep 4, 2020

The documented interface (run) does not allow overriding the pre-commit package, so realistically I don't expect this to be a problem now.
If anyone decides to use the modules directly for example, they can override the pre-commit.package option, in which case they don't import this file.

It does touch #55, about being able to provide your own packages.

@blaggacao
Copy link
Contributor Author

blaggacao commented Sep 4, 2020 •
edited
Loading

Hm, after (quite) a while I was able to figure this out as well. Since you seem about to refactor some things around those aspects, I'm closing this for now. Thanks for your initiative!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roberth @blaggacao