Skip to content

Ability to select specific versions of tooling #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fiadliel opened this issue Jul 24, 2020 · 3 comments
Closed

Ability to select specific versions of tooling #55

fiadliel opened this issue Jul 24, 2020 · 3 comments

Comments

@fiadliel
Copy link
Contributor

Whether through passing in your own nixpkgs, sources.json, or otherwise, it would be nice to be able to influence the versions of tooling chosen, without having to fork the project.

A concrete case:
haskell-language-server for VSCode uses a specific version of ormolu for formatting, and this is built-in to the server as a library, not binary (with current hls, 0.1.2.0). If we can't align ormolu with the version pre-commit-hooks uses, then the feature in HLS/VSCode cannot reasonably be used concurrently with hooks (which is a pity for usability etc.).

@domenkozar
Copy link
Member

It's possible to do that via pre-commit.tools or entry but you have to read the source to get it right.

It would be far better if we exposed package per each tool that could be overriden.

@domenkozar
Copy link
Member

Similar to #61

@domenkozar
Copy link
Member

This is now fixed, you can set package for each hook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants