-
Notifications
You must be signed in to change notification settings - Fork 35
refactor: componentize changes #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: componentize changes #203
Conversation
3f9153d
to
930c011
Compare
930c011
to
ff0f3e6
Compare
Setting this to draft while #202 lands -- the functionality in here will have to change quite a bit. |
799820f
to
e8c8650
Compare
a373f76
to
391894e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you by any chance be able to split this into two commits, where one only does pure movement of code that's otherwise unmodified, and the other makes whatever functional or structural changes are contained?
I started reviewing this, but found myself jumping around and trying to follow where there are real changes, vs where a function has just moved to a different location in the file, and found that very hard to do.
(I appreciate that my last big PR to this repo did a lot of the same. I tried minimizing code movement in that, but in hindsight should nevertheless have split the movement that I did apply off into its own commit.) |
Definitely can do -- I'll split this into more commits so it's a bit easier |
5924e1c
to
a98a681
Compare
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
a98a681
to
99c8460
Compare
1550cdc
to
99c8460
Compare
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
e144a6d
to
5a5d5f3
Compare
Signed-off-by: Victor Adossi <[email protected]>
5a5d5f3
to
52c2981
Compare
Hey @tschneidereit so it turned into 8 commits 😅 -- hopefully these changes are easier to follow. |
This refactoring makes a few changes to the code to make componentize-js a bit easier to debug: