Skip to content

Sanitize binary args passed by user #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2019
Merged

Sanitize binary args passed by user #73

merged 3 commits into from
May 2, 2019

Conversation

ss3681755
Copy link
Contributor

No description provided.

francisf
francisf approved these changes May 2, 2019
View reviewed changes
Copy link
Collaborator

@francisf francisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.. need a long term fix so as to not escape paths. correct fix would be to use literal paths and not manually put double quotes, instead fix the exec and other calls to redirect to files/fds instead of manual command line.

@mohitmun mohitmun changed the base branch from master to pre_prod May 2, 2019 12:23
@mohitmun mohitmun merged commit 9d17e62 into browserstack:pre_prod May 2, 2019
@mohitmun mohitmun mentioned this pull request May 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francisf francisf francisf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ss3681755 @francisf @mohitmun @singh811