-
-
Notifications
You must be signed in to change notification settings - Fork 10
Update deps, add readable-stream #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps, add readable-stream #14
Conversation
Thanks. Am I understand correctly, that this can be published as minor version? |
Yep, very safe, readable-stream is the source of the Node core |
Published as 3.1.0 |
Hello @rvagg, I'd be interested in what the breaking changes are that you were talking about and how they affect this library or ripemd160? |
nodejs/readable-stream@c5897e3 this The removal of the top-level entry points is the main one i keep on hitting. I can't recall if it was coming up here, but probably. Some folks got in the habit of writing things like |
Alright, thanks for the answer! |
turns out this was a breaking change in that it drops node < 4, which v3.0.0 supports. |
the main thing here is switching out
stream
forreadable-stream
. With Webpack not updating their node-libs-browser we're not getting a newer version of stream-browserify so things break because of breaking changes in readable-stream. So this just bypasses that problem entirely and goes straight to readable-stream which it's using anyway. Also pinning to readable-stream gives some nice stability guarantees.I'm using this through ripemd160 for btc stuff btw, 👍 on that.