Restore missing symlink to python in docker image (SCP-4547) #299
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates to
Dockerfile
andrequirements.txt
to fix broken ingest docker image:This docker image update may be more easily evaluated by checking that portal core integration tests pass. For those who wish to test at this stage, the following instructions are for manual testing:
To test, follow README instructions for Testing in Docker locally Steps 1,2 & 4
Once in the docker container, set up to bypass the mongo database requirement:
export BYPASS_MONGO_WRITES='yes'
Test ingest of cluster and metadata files should succeed (despite unregistered study-id and study-file-id provided):
python ingest_pipeline.py --study-id 5d276a50421aa9117c982845 --study-file-id 5dd5ae25421aa910a723a337 ingest_cell_metadata --cell-metadata-file ../tests/data/annotation/metadata/convention/valid_no_array_v2.0.0.txt --study-accession SCP123 --ingest-cell-metadata
python ingest_pipeline.py --study-id 5d276a50421aa9117c982845 --study-file-id 5dd5ae25421aa910a723a337 ingest_cluster --cluster-file ../tests/data/cluster_example.txt --ingest-cluster --name cluster1 --domain-ranges "{'x':[-1, 1], 'y':[-1, 1], 'z':[-1, 1]}"
Test ingest of expression matrix file will fail (due to unregistered study-id and study-file-id provided) with:
for reference, expression matrix ingest command:
python ingest_pipeline.py --study-id 5d276a50421aa9117c982845 --study-file-id 5dd5ae25421aa910a723a337 ingest_expression --taxon-name 'Homo sapiens' --taxon-common-name human --ncbi-taxid 9606 --matrix-file ../tests/data/dense_matrix_19_genes_1000_cells.txt --matrix-file-type dense
Expression matrix validity can be tested by pointing a portal core instance to an ingest docker image with a docker build from this PR (eg. gcr.io/broad-singlecellportal-staging/scp-ingest-jlc_fix_image:e42abd1) and running the
test_create_default_testing_study
integration test:bin/run_tests.sh -l -t test/integration/study_creation_test.rb
The above test would also validate metadata and cluster ingest.