DDP-6918 [Pancan] Fix autocomplete scrolling #869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @HostListener('window: scroll') public onWindowScroll(): void { | ||
| if (this.autoComplete?.panelOpen) { | ||
| this.autoComplete.closePanel(); |
There was a problem hiding this comment.
how about using updatePosition api (https://material.angular.io/components/autocomplete/api) instead of closing the popup?
There was a problem hiding this comment.
It does not help in our case.
There was a problem hiding this comment.
Agreed to keep the autocomplete dropdown under the header by scrolling.
as to keep autocomplete dropdowns under the header by scrolling
alextanlan
changed the title
| @@ -44,12 +54,13 @@ import { ConfigurationService } from '../../../services/configuration.service'; | |||
| `] | |||
| }) | |||
| export class AutocompleteActivityPicklistQuestion extends BaseActivityPicklistQuestion implements OnInit, OnDestroy, OnChanges { | |||
| private readonly ngUnsubscribe = new Subject(); | |||
| @ViewChild(MatAutocompleteTrigger, {read: MatAutocompleteTrigger}) autoComplete: MatAutocompleteTrigger; | |||
There was a problem hiding this comment.
let's remove this viewchild property
aglushko-broad
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a case when an autocomplete list is scrolled above the header.
Before:
After:
