Skip to content

Remove unsupported tests and use more complete rised error #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2022
Merged

Remove unsupported tests and use more complete rised error #1

merged 1 commit into from
Sep 5, 2022

Conversation

Kislovskiy
Copy link

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@Kislovskiy
Copy link
Author

@brisvag hey Lorenzo, I think we should merge this in your branch, it will resolve the failing tests

brisvag
brisvag approved these changes Sep 5, 2022
View reviewed changes
Copy link
Owner

@brisvag brisvag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@brisvag brisvag merged commit 7c0765e into brisvag:fix/non-ns-time Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brisvag brisvag brisvag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kislovskiy @brisvag