add lint when comparing floats in an array

briankabiro · briankabiro · commit 99445f998f5b · 2019-08-06T18:03:26.000+03:00
Finishes rust-lang#4277
diff --git a/clippy_lints/src/misc.rs b/clippy_lints/src/misc.rs
@@ -519,7 +519,8 @@ fn is_signum(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
 }
 
 fn is_float(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
-    matches!(walk_ptrs_ty(cx.tables.expr_ty(expr)).sty, ty::Float(_))
+    let value = walk_ptrs_ty(cx.tables.expr_ty(expr)).sty;
+    matches!(value, ty::Float(_)) || matches!(value, ty::Array(ty::Float, _))
 }
 
 fn check_to_owned(cx: &LateContext<'_, '_>, expr: &Expr, other: &Expr) {

Original file line number	Diff line number	Diff line change
`@@ -519,7 +519,8 @@ fn is_signum(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {`
`519`	`519`	`}`
`520`	`520`
`521`	`521`	`fn is_float(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {`
`522`		`- matches!(walk_ptrs_ty(cx.tables.expr_ty(expr)).sty, ty::Float(_))`
	`522`	`+ let value = walk_ptrs_ty(cx.tables.expr_ty(expr)).sty;`
	`523`	`+ matches!(value, ty::Float(_)) \|\| matches!(value, ty::Array(ty::Float, _))`
`523`	`524`	`}`
`524`	`525`
`525`	`526`	`fn check_to_owned(cx: &LateContext<'_, '_>, expr: &Expr, other: &Expr) {`