Skip to content

Commit 3b1fb55

Browse files
committed
Fixed simple field None value, CenterForOpenScience#238
1 parent 66f2b4b commit 3b1fb55

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

pydocx/openxml/wordprocessing/simple_field.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ def _parse_instr_arg_string_to_args(self, arg_string):
3838
return re.findall(r'\s*(?:"([^"]+)"|([^\s]+))+', arg_string)
3939

4040
def parse_instr(self):
41+
if self.instr is None:
42+
return
4143
m = self._parse_instr_into_field_type_and_arg_string()
4244
if not m:
4345
return

tests/export/html/test_simple_field.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,10 @@ def parse(self, instr):
202202
field = SimpleField(instr=instr)
203203
return field.parse_instr()
204204

205+
def test_with_None_instr_returns_None(self):
206+
result = self.parse(None)
207+
self.assertEqual(result, None)
208+
205209
def test_with_blank_instr_returns_None(self):
206210
result = self.parse('')
207211
self.assertEqual(result, None)

0 commit comments

Comments
 (0)