Support custom names for chunk and imports file. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM @izaakschroeder |
|
👍 LGTM |
Previously the name of both the split files _and_ the imports file were fixed. For split files they were just the name of the source asset with a `-i` tacked on; for import files they always overwrote the original asset. Both of these are now customizable using the standard webpack name interpolator; you get things like `[name]`, `[ext]` and so forth. For the split files you also get an additional `[part]` value that signifies the current part. Additionally, this allows for one to generate both the split files and imports _as well as_ keep the original unsplit files. This may be desirable in cases where you only wish to serve the split files to a specific target (i.e. IE) and use the unsplit files everywhere else.
Cause knowing what things do is good.
izaakschroeder
force-pushed
the
custom-names
branch
from
3ceea20 to
f2c9ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the name of both the split files and the imports file were fixed. For split files they were just the name of the source asset with a
-itacked on; for import files they always overwrote the original asset. Both of these are now customizable using the standard webpack name interpolator; you get things like[name],[ext]and so forth. For the split files you also get an additional[part]value that signifies the current part.Additionally, this allows for one to generate both the split files and imports as well as keep the original unsplit files. This may be desirable in cases where you only wish to serve the split files to a specific target (i.e. IE) and use the unsplit files everywhere else.