ci: move Rust caching into our setup action

To avoid duplicative content.

And add comments for why we're changing some of the options.

Signed-off-by: Colin Walters <[email protected]>

Author: cgwalters

.github/actions/bootc-ubuntu-setup/action.yml

@@ -45,3 +45,13 @@ runs:
       id: set_arch
       shell: bash
       run: echo "ARCH=$(arch)" >> $GITHUB_ENV
+    # We often use Rust, so set up opinionated default caching
+    - name: Setup Rust cache
+      uses: Swatinem/rust-cache@v2
+      with:
+        cache-all-crates: true
+        # Only generate caches on push to git main
+        save-if: ${{ github.ref == 'refs/heads/main' }}
+        # Suppress actually using the cache for builds running from
+        # git main so that we avoid incremental compilation bugs
+        lookup-only: ${{ github.ref == 'refs/heads/main' }}

.github/workflows/ci.yml

@@ -32,12 +32,6 @@ jobs:
       - uses: actions/checkout@v4
       - name: Bootc Ubuntu Setup
         uses: ./.github/actions/bootc-ubuntu-setup
-      - name: Setup Rust cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          cache-all-crates: true
-          save-if: ${{ github.ref == 'refs/heads/main' }}
-          lookup-only: ${{ github.ref == 'refs/heads/main' }}
       - name: Validate (default)
         run: just validate
   # Build container with continuous repository enabled
@@ -47,12 +41,6 @@ jobs:
       - uses: actions/checkout@v4
       - name: Bootc Ubuntu Setup
         uses: ./.github/actions/bootc-ubuntu-setup
-      - name: Setup Rust cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          cache-all-crates: true
-          save-if: ${{ github.ref == 'refs/heads/main' }}
-          lookup-only: ${{ github.ref == 'refs/heads/main' }}
       - name: Build with continuous repo enabled
         run: sudo just build --build-arg=continuous_repo=1
   # Check for security vulnerabilities and license compliance
@@ -74,12 +62,6 @@ jobs:
         uses: actions/checkout@v4
       - name: Bootc Ubuntu Setup
         uses: ./.github/actions/bootc-ubuntu-setup
-      - name: Setup Rust cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          cache-all-crates: true
-          save-if: ${{ github.ref == 'refs/heads/main' }}
-          lookup-only: ${{ github.ref == 'refs/heads/main' }}
       - name: Enable fsverity for /
         run: sudo tune2fs -O verity $(findmnt -vno SOURCE /)
       - name: Install utils
@@ -133,12 +115,6 @@ jobs:
       - uses: actions/checkout@v4
       - name: Bootc Ubuntu Setup
         uses: ./.github/actions/bootc-ubuntu-setup
-      - name: Setup Rust cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          cache-all-crates: true
-          save-if: ${{ github.ref == 'refs/heads/main' }}
-          lookup-only: ${{ github.ref == 'refs/heads/main' }}
       - name: Build mdbook
         run: just build-mdbook
   # Build containers and disk images for integration testing across OS matrix
@@ -154,12 +130,6 @@ jobs:
       - uses: actions/checkout@v4
       - name: Bootc Ubuntu Setup
         uses: ./.github/actions/bootc-ubuntu-setup
-      - name: Setup Rust cache
-        uses: Swatinem/rust-cache@v2
-        with:
-          cache-all-crates: true
-          save-if: ${{ github.ref == 'refs/heads/main' }}
-          lookup-only: ${{ github.ref == 'refs/heads/main' }}
       - name: Install qemu-utils
         run: sudo apt install -y qemu-utils