Checker no mangle

[mheiber]

checker changes for private names

compare with the symbol-table-key-mangling solution in a separate PR

• treat private names as unique:
  • case 1: cannot say that a variable is of a class type unless the variable points to an instance of the class
    • see test
    • solution implemented:
      • When appending a declaration to a symbol, if the declaration name is a private name then add SymbolFlags.PrivateNamed
      • When checking for unmatched properties, consider a property unmatched if it has the PrivateNamed flag. This has the desired effect of nominalizing classes with private-named members.
  • case 2: private names in class hierarchies do not conflict
    • see test
    • solution implemented:
      • in issueMemberSpecificError, the compiler check for members of conflicting types. We just skip the check if the member is a private name.
• #constructor is reserved
  • see test
  • check in bindWorker, where every node is visited
• Accessibility modifiers can't be used with private names
  • see test
  • implemented in checkAccessibilityModifiers, using ModifierFlags.AccessibilityModifier
• delete #foo not allowed
• Private name accesses not allowed outside of the defining class
  • see test: https://github.com/mheiber/TypeScript/tree/checker/tests/cases/conformance/classes/members/privateNames/privateNameNotAccessibleOutsideDefiningClass.ts
  • see test
  • implemented in checkDeleteExpression